Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt-github-actions: run githubWorkflowGenerate after build.sbt changes #1984

Closed
kubukoz opened this issue Mar 1, 2021 · 3 comments · Fixed by #1993
Closed

sbt-github-actions: run githubWorkflowGenerate after build.sbt changes #1984

kubukoz opened this issue Mar 1, 2021 · 3 comments · Fixed by #1993
Assignees
Labels
enhancement New feature or request

Comments

@kubukoz
Copy link
Contributor

kubukoz commented Mar 1, 2021

Follow-up to #1745.

Some changes in build.sbt may cause a change to the workflow files, e.g. a Scala version upgrade.

In these situations, Steward could regenerate the YAML configs as well. The exact keys that can influence that result might be hard to detect, so I guess it could run automatically on every change to .sbt / .scala build files if there's sbt-github-actions in the build.

@fthomas
Copy link
Member

fthomas commented Mar 3, 2021

I like this but would restrict it to Scala updates. Nearly all Scala Steward PRs change .sbt or .scala files which means we would need to run sbt githubWorkflowGenerate on all updates if sbt-github-actions is used. That could slow down Scala Steward considerably because running sbt is slow.

@fthomas fthomas added the enhancement New feature or request label Mar 3, 2021
@kubukoz
Copy link
Contributor Author

kubukoz commented Mar 3, 2021

right, if we can't reuse the previous session with a reload it probably doesn't make sense to run every time. 👍

@fthomas fthomas self-assigned this Mar 5, 2021
@fthomas
Copy link
Member

fthomas commented Mar 5, 2021

We do not run sbt every time a PR is created, so in most cases there is just no previous sbt session we could reuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants