Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scala3-compiler, scala3-library, ... 3.1.3-RC3 (was 3.1.3-RC2) #759

Conversation

scala-steward
Copy link
Contributor

Updates

from 3.1.3-RC2 to 3.1.3-RC3.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Files still referring to the old version number

The following files still refer to the old version number (3.1.3-RC2).
You might want to review and update them manually.

.github/workflows/build-test.yml
Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "org.scala-lang" }
}]

labels: library-update, early-semver-pre-release, semver-spec-pre-release, old-version-remains, commit-count:1

@ihostage
Copy link
Member

@mkurz Do you know, why @scala-steward can't find the same version in .github/workflows/build-test.yml? 🤔
I known about scala-steward-org/scala-steward#1984, but I don't want to write a custom githubWorkflowGenerate for do these changes 😄 I think we have a very simple case when need to find and change the similar string in .yml file enough. And by default @scala-steward (https://github.com/scala-steward-org/scala-steward/blob/0a4d1a09b47760b51c89870db3ba25430aae8ad2/docs/repo-specific-configuration.md?plain=1#L61) should do that. Or am I wrong?

@ihostage
Copy link
Member

@fthomas maybe you can help and describe, why Steward can't find the same Scala version in

scala: 2.12.15, 2.13.8, 3.1.3-RC2
🙏

@ihostage
Copy link
Member

I'm really think that we shouldn't sync version between GA and SBT manually and needs to find an automation solution 😄

@mkurz
Copy link
Member

mkurz commented May 16, 2022

Maybe that is a bug in scala-steward? Maybe because the .github folder is hidden? This needs more investigation...

@mkurz
Copy link
Member

mkurz commented May 16, 2022

Hmm... maybe scala-steward only looks for files up to the second level of the folder hierarchy? So build.sbt is in the first level (. root folder), project/plugins.sbt is at the second level, but .github/workflows/build-test.yml is in the third level.
That could also explain why project/project/plugins.sbt will not be updated: scala-steward-org/scala-steward#2548

@mkurz
Copy link
Member

mkurz commented May 16, 2022

Fix for scala-steward-org/scala-steward#2548 submitted, however the original problem still persists...
(BTW: There is also postUpdateHooks, however this is also not so nice to use...)

@ihostage
Copy link
Member

scala-steward-org/scala-steward#2605 for scala-steward-org/scala-steward#2548 submitted

👍

(BTW: There is also postUpdateHooks, however this is also not so nice to use...)

Yep, I saw that. But I really think that for our case is too much 😄 We just want to change a version in two files instead one 😄 I don't want to write a hook for that 😂

@mkurz
Copy link
Member

mkurz commented May 19, 2022

Reported as scala-steward-org/scala-steward#2608
Replaced this pull requeset with #762 to preserve it for the bug report.

@mkurz mkurz closed this May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants