Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan project/project/... folders #2605

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

mkurz
Copy link
Contributor

@mkurz mkurz commented May 16, 2022

Fixes #2548

@codecov
Copy link

codecov bot commented May 16, 2022

Codecov Report

Merging #2605 (3da3607) into main (6f2da8b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2605      +/-   ##
==========================================
+ Coverage   81.08%   81.10%   +0.01%     
==========================================
  Files         144      144              
  Lines        2538     2540       +2     
  Branches       46       48       +2     
==========================================
+ Hits         2058     2060       +2     
  Misses        480      480              
Impacted Files Coverage Δ
...a/org/scalasteward/core/buildtool/sbt/SbtAlg.scala 98.11% <100.00%> (ø)
.../org/scalasteward/core/buildtool/sbt/package.scala 100.00% <0.00%> (ø)
...rg/scalasteward/core/edit/hooks/HookExecutor.scala 90.32% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2da8b...3da3607. Read the comment docs.

@mkurz
Copy link
Contributor Author

mkurz commented May 19, 2022

Anyone?

…t/SbtAlg.scala

Co-authored-by: TATSUNO Yasuhiro <ytatsuno.jp@gmail.com>
@mkurz
Copy link
Contributor Author

mkurz commented May 20, 2022

Thanks @exoego could you also have a look at #2608 😉 ?

@exoego exoego added the enhancement New feature or request label Jun 15, 2022
@exoego
Copy link
Contributor

exoego commented Jun 15, 2022

Sorry for long waiting and thanks your effort.

@exoego exoego merged commit cb45f7c into scala-steward-org:main Jun 15, 2022
@fthomas fthomas added this to the 0.15.0 milestone Jun 15, 2022
@mkurz mkurz deleted the fix_project_subfolder branch July 4, 2022 12:46
@mkurz
Copy link
Contributor Author

mkurz commented Oct 20, 2022

@fthomas @exoego Do you know why this is not working? scala-steward never updated https://github.com/playframework/playframework/blob/main/project/project/buildinfo.sbt but with this patch here it actually should... There is version 0.11.0 available on maven central: https://repo1.maven.org/maven2/com/eed3si9n/sbt-buildinfo_2.12_1.0/ - but not 0.10.0, it was hosted on bintray before I think. Could that be the reason?
Thanks for you help!

@mkurz
Copy link
Contributor Author

mkurz commented Oct 31, 2022

Hey @fthomas and @exoego, quick question:
Now this pull request should be live already, I was wondering why https://github.com/playframework/playframework/blob/main/project/project/buildinfo.sbt was not updated to use sbt-buildinfo 0.11.0 already.
I guess that this is because on Maven Central only hosts one version, the latest 0.11.0: https://repo1.maven.org/maven2/com/eed3si9n/sbt-buildinfo_2.12_1.0/ Previous releases where hosted at a Lightbend server.
Is it possible that Scala Steward does not recognice an "update" of that library anymore because there was no bump from 0.10.0 to 0.11.0 in Maven Central (or because this pull request was merged after 0.11.0 got published on Maven Central, so scala steward already "caches" 0.11.0 as latest version)?
Is it possible to re-trigger scala-stewards so he updates all repos to 0.11.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not updating dependencies in /project/project/ folder
3 participants