Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Scala version upgrade when using sbt-github-actions #2154

Closed
NthPortal opened this issue May 30, 2021 · 2 comments · Fixed by #2316
Closed

Broken Scala version upgrade when using sbt-github-actions #2154

NthPortal opened this issue May 30, 2021 · 2 comments · Fixed by #2316
Labels
bug Something isn't working

Comments

@NthPortal
Copy link
Contributor

The first commit to update the Scala version only modifies ci.yml, but not build.sbt. The second commit to regenerate ci.yml then undoes the change.

See NthPortal/extra-predef#73 for example.

@fthomas
Copy link
Member

fthomas commented Jul 12, 2021

Thanks for the report @NthPortal! typelevel/shapeless-3#25 and typelevel/ce3.g8#27 are other examples of this bug.

@fthomas fthomas added the bug Something isn't working label Jul 12, 2021
@fthomas
Copy link
Member

fthomas commented Oct 11, 2021

A simple workaround for this issue would be to add a check in NurtureAlg.applyNewUpdate that the diff between the update branch and the base branch is non-empty.

I think that is easier than fixing the underlying issue that we're recording the Scala version that is used to compile the build as a dependency of the project. For that we would need to exclude Scala libraries from libraryDependencies after reload plugins.

fthomas added a commit that referenced this issue Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants