Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong dependency gets updated #960

Closed
psttf opened this issue Sep 17, 2019 · 2 comments · Fixed by #1947
Closed

Wrong dependency gets updated #960

psttf opened this issue Sep 17, 2019 · 2 comments · Fixed by #1947
Labels
bug Something isn't working

Comments

@psttf
Copy link
Contributor

psttf commented Sep 17, 2019

I've noticed the following unexpected behavior: if there are two dependencies in build.sbt with the same version number and one of them is marked as ignored Steward updates the wrong dependency.

Minimal sample project: https://gitlab.com/psttf/scala-steward-issue

It has dependencies to Bootstrap and jQuery webjars with the same version number. Bootstrap is marked as ignored via comment. Still, Steward tries to update Bootstrap and updates jQuery instead and duplicates jQuery dependency. In my other (non-minimal) project with the same problem duplication does not occur.

PR created by Steward: https://gitlab.com/psttf/scala-steward-issue/merge_requests/1

The PR is named "Update bootstrap to 4.3.1" but it updates jQuery instead!

I use Docker Hub image fthomas/scala-steward:latest to run scala-steward, image sha256:fdc23a0f2d89b299be4f8f865cb274ba2e64730d355c4cfb7793b55da0906344

fthomas added a commit that referenced this issue Feb 20, 2021
@fthomas fthomas added the bug Something isn't working label Feb 20, 2021
fthomas added a commit that referenced this issue Feb 20, 2021
@psttf
Copy link
Contributor Author

psttf commented Feb 20, 2021

Thank you for fixing this!

@fthomas
Copy link
Member

fthomas commented Feb 20, 2021

It was about time! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants