Merge MockState#{commands, logs} to MockState#trace #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merges the `commands` and `logs` field of `MockState` into one `trace` field that is a `Vector` of `Cmd`s and `Log`s. The advantage of this change is that commands and logs in `MockState` are now interleaved so that we can check their order in the tests.
Codecov Report
@@ Coverage Diff @@
## master #1954 +/- ##
=======================================
Coverage 78.35% 78.35%
=======================================
Files 129 129
Lines 2227 2227
Branches 60 60
=======================================
Hits 1745 1745
Misses 482 482 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the
commandsandlogsfield ofMockStateinto onetracefield that is aVectorofCmds andLogs. The advantage ofthis change is that commands and logs in
MockStateare now interleavedso that we can check their order in the tests.