Do not use sbt's logger to print stewardDependencies #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sbt's logger is configured to not print info messages, for example via `logLevel := Level.Warn`, Scala Steward will not receive any information about dependencies from sbt. Using `println` here should fix that.
Codecov Report
@@ Coverage Diff @@
## master #1994 +/- ##
=======================================
Coverage 78.74% 78.74%
=======================================
Files 131 131
Lines 2263 2263
Branches 65 65
=======================================
Hits 1782 1782
Misses 481 481
Continue to review full report at Codecov.
|
|
This reverts #1180 but unfortunately that ticket gives no reason for switching from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sbt's logger is configured to not print info messages, for example
via
logLevel := Level.Warn, Scala Steward will not receive anyinformation about dependencies from sbt. Using
printlnhere shouldfix that.