Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings about unused moduleRootPkg key #2016

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Mar 19, 2021

This fixes these warnings:

[warn] there are 4 keys that are not used by any other settings/tasks:
[warn]
[warn] * benchmark / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn] * mill-plugin / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn] * root / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:305
[warn] * sbt-plugin / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn]
[warn] note: a setting might still be used by a command; to exclude a key from this `lintUnused` check
[warn] either append it to `Global / excludeLintKeys` or call .withRank(KeyRanks.Invisible) on the key

This fixes these warnings:
```
[warn] there are 4 keys that are not used by any other settings/tasks:
[warn]
[warn] * benchmark / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn] * mill-plugin / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn] * root / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:305
[warn] * sbt-plugin / moduleRootPkg
[warn]   +- /home/runner/work/scala-steward/scala-steward/build.sbt:202
[warn]
[warn] note: a setting might still be used by a command; to exclude a key from this `lintUnused` check
[warn] either append it to `Global / excludeLintKeys` or call .withRank(KeyRanks.Invisible) on the key
```
@fthomas fthomas added the build label Mar 19, 2021
@fthomas fthomas added this to the 0.10.0 milestone Mar 19, 2021
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #2016 (31dd3dc) into master (8e59be5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2016   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files         131      131           
  Lines        2252     2252           
  Branches       52       52           
=======================================
  Hits         1770     1770           
  Misses        482      482           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e59be5...31dd3dc. Read the comment docs.

@fthomas fthomas merged commit e5dd20b into master Mar 19, 2021
@fthomas fthomas deleted the topic/fix-sbt-warnings branch March 20, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant