Add refresh back-off period configuration #2171
Conversation
| @@ -58,7 +58,8 @@ object Cli { | |||
| githubAppKeyFile: Option[File] = None, | |||
| githubAppId: Option[Long] = None, | |||
| urlCheckerTestUrl: Option[Uri] = None, | |||
| defaultMavenRepo: Option[String] = None | |||
| defaultMavenRepo: Option[String] = None, | |||
| refreshBackoffPeriod: Option[FiniteDuration] = None | |||
There was a problem hiding this comment.
I wasn't sure if set the default at this level or when creating the Config. Might make more sense to set it here than where I wrote it
There was a problem hiding this comment.
Most default values are set here, so I guess it makes sense to also set it here for refreshBackoffPeriod.
There was a problem hiding this comment.
Yeah, I will change that, thanks!
|
I will add the config to the docs when we agree on the approach |
There was a problem hiding this comment.
This LGTM, many thanks @javierarrieta.
So to disable any refresh backoff, one just passes --refresh-backoff-period 0days as CLI option.
| @@ -58,7 +58,8 @@ object Cli { | |||
| githubAppKeyFile: Option[File] = None, | |||
| githubAppId: Option[Long] = None, | |||
| urlCheckerTestUrl: Option[Uri] = None, | |||
| defaultMavenRepo: Option[String] = None | |||
| defaultMavenRepo: Option[String] = None, | |||
| refreshBackoffPeriod: Option[FiniteDuration] = None | |||
There was a problem hiding this comment.
Most default values are set here, so I guess it makes sense to also set it here for refreshBackoffPeriod.
Yes, I will add it to the docs in this PR, let's see if I fixed the build |
Codecov Report
@@ Coverage Diff @@
## master #2171 +/- ##
=======================================
Coverage 78.16% 78.17%
=======================================
Files 131 131
Lines 2249 2250 +1
Branches 57 46 -11
=======================================
+ Hits 1758 1759 +1
Misses 491 491
Continue to review full report at Codecov.
|
|
Documentation added to the help.md file, would that be enough? |
Yes, thanks! |
|
Thanks for the quick turnaround and mostly thanks for this great piece of software that help many of us with their day to day |
Add refresh back-off period configuration
Fixes #1912