-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce EditAttempt enum #2242
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2242 +/- ##
==========================================
+ Coverage 78.23% 78.31% +0.08%
==========================================
Files 131 132 +1
Lines 2265 2283 +18
Branches 48 57 +9
==========================================
+ Hits 1772 1788 +16
- Misses 493 495 +2
Continue to review full report at Codecov.
|
@@ -42,7 +41,6 @@ final class NurtureAlg[F[_]](config: Config)(implicit | |||
gitAlg: GitAlg[F], | |||
logger: Logger[F], | |||
pullRequestRepository: PullRequestRepository[F], | |||
scalafixMigrationsFinder: ScalafixMigrationsFinder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That we can get rid of ScalafixMigrationsFinder
in NurtureAlg
is what I like most about this change.
This introduces the
EditAttempt
enum for the different types of edits Scala Steward can do in a PR: version bumps, Scalafix changes, and post-update hooks changes. The purpose of this change is that we can in the future use the list ofEditAttempts
returned byEditAlg
to create more faithful PR bodies that better reflect what Scala Steward did: for example only mention Scalafix migrations if they result in changes, indicate if a Scalafix migration failed, or add labels for post-update hooks., etc.