Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved content parser for .mill-version file #2247

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Improved content parser for .mill-version file #2247

merged 1 commit into from
Sep 23, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Sep 22, 2021

Fix sugested by Frank Thomas.

@lefou
Improved content parser for .mill-version file
7cb87d8 
Fix sugested by Frank Thomas.
@codecov
Copy link

codecov bot commented Sep 22, 2021 •
edited
Loading

Codecov Report

Merging #2247 (7cb87d8) into master (32c1c61) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2247   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files         131      131           
  Lines        2268     2268           
  Branches       56       57    +1     
=======================================
  Hits         1775     1775           
  Misses        493      493
Impacted Files Coverage Δ
...a/org/scalasteward/core/edit/UpdateHeuristic.scala 98.83% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c1c61...7cb87d8. Read the comment docs.

exoego
exoego approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fthomas fthomas merged commit 92f5161 into scala-steward-org:master Sep 23, 2021
@fthomas fthomas added this to the 0.11.0 milestone Sep 23, 2021
@fthomas fthomas added the enhancement New feature or request label Sep 23, 2021
@lefou lefou deleted the fix-mill-version-parser branch September 23, 2021 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fthomas fthomas fthomas approved these changes

@exoego exoego exoego approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lefou @exoego @fthomas