Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not close old PRs that were manually updated #2254

Merged
merged 4 commits into from
Sep 29, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Sep 28, 2021

This changes the logic for closing obsolete PRs such that only PRs which
were not manually updated are closed and the corresponding update branch
is deleted. If an obsolete update branch contains commits by authors
other than Scala Steward, only the "Superseded by" comment is posted to the
old PR.

Closes: #1871

This changes the logic for closing obsolete PRs such that only PRs which
were not manually updated are closed and the corresponding update branch
is deleted. If an obsolete update branch contains commits by authors
other than Scala Steward, only the "Superseded by" comment is posted to the
old PR.

Closes: #1871
@fthomas fthomas added the enhancement New feature or request label Sep 28, 2021
@fthomas fthomas added this to the 0.12.0 milestone Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #2254 (d7c0ea3) into master (d871194) will decrease coverage by 0.35%.
The diff coverage is 9.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2254      +/-   ##
==========================================
- Coverage   78.29%   77.93%   -0.36%     
==========================================
  Files         135      135              
  Lines        2271     2284      +13     
  Branches       50       58       +8     
==========================================
+ Hits         1778     1780       +2     
- Misses        493      504      +11     
Impacted Files Coverage Δ
.../main/scala/org/scalasteward/core/git/Branch.scala 75.00% <0.00%> (-25.00%) ⬇️
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% <0.00%> (ø)
...in/scala/org/scalasteward/core/git/GenGitAlg.scala 92.30% <50.00%> (+0.30%) ⬆️
...n/scala/org/scalasteward/core/git/FileGitAlg.scala 98.27% <66.66%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d871194...d7c0ea3. Read the comment docs.

@fthomas fthomas merged commit 2f7b9cf into master Sep 29, 2021
@fthomas fthomas deleted the topic/do-not-close-modified-prs branch September 30, 2021 06:19
@fthomas
Copy link
Member Author

fthomas commented Oct 15, 2021

This does not work if Scala Steward's commits are changed and force-pushed. An example is scalacenter/scalafix#1483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature idea: don't close superseded PRs if they were manually updated
1 participant