Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cats-parse instead of atto for the Maven parser #2275

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 11, 2021

The reason for this change is to have less parsing libraries.

The reason for this change is to have less parsing libraries.
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #2275 (ec45673) into master (5b2e2d5) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2275      +/-   ##
==========================================
+ Coverage   77.95%   77.97%   +0.01%     
==========================================
  Files         135      135              
  Lines        2295     2297       +2     
  Branches       52       50       -2     
==========================================
+ Hits         1789     1791       +2     
  Misses        506      506              
Impacted Files Coverage Δ
...org/scalasteward/core/buildtool/maven/parser.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2e2d5...ec45673. Read the comment docs.

@fthomas fthomas added this to the 0.12.0 milestone Oct 12, 2021
@fthomas fthomas merged commit 4354d6c into master Oct 12, 2021
@fthomas fthomas deleted the topic/replace-atto branch October 13, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant