Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log errors in CoursierAlg#getVersions #2277

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Conversation

L7R7
Copy link
Contributor

@L7R7 L7R7 commented Oct 12, 2021

This refers to #2276. As mentioned in #2202, it's only logged on TRACE level

@L7R7 L7R7 force-pushed the master branch 2 times, most recently from 7a45d7d to 0b6fc93 Compare October 12, 2021 11:10
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #2277 (22c3842) into master (4354d6c) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2277      +/-   ##
==========================================
- Coverage   77.97%   77.93%   -0.04%     
==========================================
  Files         135      135              
  Lines        2297     2293       -4     
  Branches       50       58       +8     
==========================================
- Hits         1791     1787       -4     
  Misses        506      506              
Impacted Files Coverage Δ
...a/org/scalasteward/core/coursier/CoursierAlg.scala 84.84% <0.00%> (ø)
...main/scala/org/scalasteward/core/vcs/package.scala 100.00% <0.00%> (ø)
...lasteward/core/nurture/PullRequestRepository.scala 92.85% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4354d6c...22c3842. Read the comment docs.

@L7R7
Copy link
Contributor Author

L7R7 commented Oct 12, 2021

I managed to get the scalafmt complaints out of the way, but I don't know how to deal with the failing codecov job yet

@fthomas
Copy link
Member

fthomas commented Oct 12, 2021

Don't worry about the codecov check. I regularly merge PRs where they are failing.

@fthomas fthomas added this to the 0.12.0 milestone Oct 12, 2021
@fthomas fthomas added the enhancement New feature or request label Oct 12, 2021
…rsierAlg.scala

Co-authored-by: Frank Thomas <f.thomas@gmx.de>
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @L7R7!

@fthomas fthomas merged commit 7a3bed1 into scala-steward-org:master Oct 13, 2021
@fthomas fthomas linked an issue Oct 13, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log errors in CoursierAlg.getVersions
2 participants