Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new examples on how to run on premise #2282

Conversation

alifirat
Copy link
Contributor

Since I'm doing a setup on a private repository, I had to look to some existing examples.

I would like to add a new example for the GitHub entreprise part, it's always helpful for the people searching how to do it on their side.

@alifirat alifirat mentioned this pull request Oct 13, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #2282 (dad5a83) into master (fc8117f) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
- Coverage   77.93%   77.83%   -0.10%     
==========================================
  Files         135      135              
  Lines        2293     2292       -1     
  Branches       58       49       -9     
==========================================
- Hits         1787     1784       -3     
- Misses        506      508       +2     
Impacted Files Coverage Δ
...n/scala/org/scalasteward/core/vcs/VCSRepoAlg.scala 76.47% <0.00%> (-15.84%) ⬇️
...la/org/scalasteward/core/application/Context.scala 77.58% <0.00%> (-7.42%) ⬇️
...a/org/scalasteward/core/scalafmt/ScalafmtAlg.scala 92.85% <0.00%> (-7.15%) ⬇️
...teward/core/vcs/bitbucket/RepositoryResponse.scala 87.50% <0.00%> (-3.81%) ⬇️
...main/scala/org/scalasteward/core/git/package.scala 100.00% <0.00%> (ø)
...main/scala/org/scalasteward/core/vcs/VCSType.scala 100.00% <0.00%> (ø)
...main/scala/org/scalasteward/core/vcs/package.scala 100.00% <0.00%> (ø)
...in/scala/org/scalasteward/core/vcs/VCSApiAlg.scala 100.00% <0.00%> (ø)
.../scala/org/scalasteward/core/application/Cli.scala 96.15% <0.00%> (ø)
...scala/org/scalasteward/core/vcs/data/RepoOut.scala 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc8117f...dad5a83. Read the comment docs.

@fthomas
Copy link
Member

fthomas commented Oct 13, 2021

Thanks for the PR @alifirat! Could you change the formatting such that the bullet point is not under the sentence that mentions Avast since the added link is not about Avast. There is also this list of blog posts that contains some posts about setting up Scala Steward on-premise. Maybe it is worth linking to that page too.

@alifirat alifirat force-pushed the new-example-to-run-steward-on-private-repo branch 3 times, most recently from 5d017eb to e6d0f9f Compare October 14, 2021 08:39
@alifirat
Copy link
Contributor Author

Hey @fthomas
I have still lint issues with the MD files but I'm not sure if I should take them in account to make the PR ok for you ?

By the way, thanks for sharing the list of blog posts, do you prefer to add a new section or update with the ones mentionning the setup of a private repository ?

@fthomas
Copy link
Member

fthomas commented Oct 14, 2021

By the way, thanks for sharing the list of blog posts, do you prefer to add a new section or update with the ones mentionning the setup of a private repository ?

I've no preference. What do you think would make more sense?

@alifirat alifirat changed the title Add a new example on how to run on premise Add a new examples on how to run on premise Oct 18, 2021
@alifirat alifirat force-pushed the new-example-to-run-steward-on-private-repo branch from e6d0f9f to dad5a83 Compare October 18, 2021 14:36
@alifirat
Copy link
Contributor Author

Hey @fthomas I take the time to choose the best articles that help people setup Steward on a private repository, no need IMO to add a new section.
Tell me if there is more thing to update :)

Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Thank you @alifirat!

@fthomas fthomas added this to the 0.12.0 milestone Oct 19, 2021
@fthomas fthomas merged commit 00a87d5 into scala-steward-org:master Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants