Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify about transient errors when cloning forks from GitHub #2285

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 14, 2021

Closes #472.

If cloning forks from GitHub fails, we adapt the error to notify
about the possibility that cloning failed because the fork is not
yet ready.

I think #472 is not severe enough to warrant a more elaborate fix.

Closes #472.

If cloning forks from GitHub fails, we adapt the error to notify
about the possibility that cloning failed because the fork is not
yet ready.

I think #472 is not severe enough to warrant a more elaborate fix.
@fthomas fthomas added this to the 0.12.0 milestone Oct 14, 2021
@fthomas fthomas added the enhancement New feature or request label Oct 14, 2021
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2285 (320bde1) into master (f601a2b) will decrease coverage by 0.09%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
- Coverage   77.93%   77.84%   -0.10%     
==========================================
  Files         135      135              
  Lines        2293     2297       +4     
  Branches       58       60       +2     
==========================================
+ Hits         1787     1788       +1     
- Misses        506      509       +3     
Impacted Files Coverage Δ
...n/scala/org/scalasteward/core/vcs/VCSRepoAlg.scala 76.47% <60.00%> (-15.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f601a2b...320bde1. Read the comment docs.

@fthomas fthomas merged commit 410dd9a into master Oct 14, 2021
@fthomas fthomas deleted the topic/adapt-git-clone-error branch October 15, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub forks are asynchronous
1 participant