Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CommitMsg case class instead of using raw strings #2302

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 20, 2021

This replaces raw strings for the Git commit message with a CommitMsg
case class. Commit messages got more structure with the addition of
the Co-authored-by: trailer so it makes sense now to defer and move
the rendering of messages into a new class.

This replaces raw strings for the Git commit message with a `CommitMsg`
case class. Commit messages got more structure with the addition of
the `Co-authored-by:` trailer so it makes sense now to defer and move
the rendering of messages into a new class.
@fthomas fthomas added this to the 0.13.0 milestone Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #2302 (1a95f0f) into master (5394a38) will increase coverage by 0.06%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
+ Coverage   77.98%   78.04%   +0.06%     
==========================================
  Files         136      137       +1     
  Lines        2298     2300       +2     
  Branches       55       59       +4     
==========================================
+ Hits         1792     1795       +3     
+ Misses        506      505       -1     
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/edit/EditAlg.scala 64.51% <0.00%> (+2.01%) ⬆️
...rg/scalasteward/core/edit/hooks/HookExecutor.scala 93.10% <100.00%> (ø)
...steward/core/edit/scalafix/ScalafixMigration.scala 100.00% <100.00%> (ø)
...in/scala/org/scalasteward/core/git/CommitMsg.scala 100.00% <100.00%> (ø)
...n/scala/org/scalasteward/core/git/FileGitAlg.scala 98.27% <100.00%> (ø)
...in/scala/org/scalasteward/core/git/GenGitAlg.scala 92.30% <100.00%> (ø)
...main/scala/org/scalasteward/core/git/package.scala 100.00% <100.00%> (ø)
...calasteward/core/vcs/data/NewPullRequestData.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5394a38...1a95f0f. Read the comment docs.

@fthomas fthomas merged commit 5ef2530 into master Oct 20, 2021
@fthomas fthomas deleted the topic/CommitMsg branch October 25, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant