Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist update branch in PullRequestRepository #2307

Merged
merged 2 commits into from
Oct 23, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Oct 22, 2021

The goal here is to use the stored update branches instead of calling
branchFor for obsolete pull requests. It should allow us to change
branchFor in the future without breaking the closing of obsolete PRs.

The goal here is to use the stored update branches instead of calling
`branchFor` for obsolete pull requests. It should allow us to change
`branchFor` in the future without breaking the closing of obsolete PRs.
@fthomas fthomas added this to the 0.13.0 milestone Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #2307 (054b6a6) into master (14d66dc) will decrease coverage by 0.30%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2307      +/-   ##
==========================================
- Coverage   78.47%   78.17%   -0.31%     
==========================================
  Files         136      136              
  Lines        2290     2318      +28     
  Branches       55       62       +7     
==========================================
+ Hits         1797     1812      +15     
- Misses        493      506      +13     
Impacted Files Coverage Δ
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% <0.00%> (ø)
...cala/org/scalasteward/core/update/PruningAlg.scala 90.14% <0.00%> (-1.29%) ⬇️
...rg/scalasteward/core/vcs/data/PullRequestOut.scala 100.00% <ø> (+33.33%) ⬆️
.../scalasteward/core/vcs/data/PullRequestState.scala 72.72% <0.00%> (-16.17%) ⬇️
...lasteward/core/nurture/PullRequestRepository.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d66dc...054b6a6. Read the comment docs.

@fthomas fthomas merged commit 72b8131 into master Oct 23, 2021
@fthomas fthomas deleted the topic/persist-update-branch branch October 25, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant