codecov v2

[pjfanning]

https://github.com/codecov/codecov-action#%EF%B8%8F--deprecration-of-v1

[exoego]

Thanks!

[exoego]

Since we do not pass any arguments to the codecov action, I assume we can migrate to v2 easily.

[fthomas]

Looks like the Codecov step failed:

[2021-10-24T21:34:16.242Z] ['info'] => Project root located at: /home/runner/work/scala-steward/scala-steward
[2021-10-24T21:34:16.244Z] ['info'] -> No token specified or token is empty
[2021-10-24T21:34:16.248Z] ['info'] Searching for coverage files...
[2021-10-24T21:34:16.601Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`

[pjfanning]

@fthomas looks like the new uploader doesn't search as hard for coverage files and might need to be configured to look in the right dirs.

Previous runs of build had these logs:

==> Reading reports
    + ./modules/mill-plugin/.jvm/target/scala-2.12/scoverage-report/scoverage.xml bytes=61500
    + ./modules/mill-plugin/.jvm/target/scala-2.12/coverage-report/cobertura.xml bytes=22696
    + ./modules/sbt-plugin/.jvm/target/scala-2.12/sbt-1.0/scoverage-report/scoverage.xml bytes=57074
    + ./modules/sbt-plugin/.jvm/target/scala-2.12/sbt-1.0/coverage-report/cobertura.xml bytes=21377
    + ./modules/core/.jvm/target/scala-2.13/scoverage-report/scoverage.xml bytes=3038365
    + ./modules/core/.jvm/target/scala-2.13/coverage-report/cobertura.xml bytes=1094392

I'll try adding more params to see if fixes the issue

[fthomas]

Sorry, I hit the "ready for review button" accidentally.

[pjfanning]

I logged codecov/uploader#463 to see if the codecov team can help.

[codecov]

Codecov Report

Merging #2311 (0e26153) into master (31fd96e) will increase coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
+ Coverage   78.17%   79.67%   +1.50%     
==========================================
  Files         136      137       +1     
  Lines        2318     2391      +73     
  Branches       62       60       -2     
==========================================
+ Hits         1812     1905      +93     
+ Misses        506      486      -20     

Impacted Files	Coverage Δ
...la/org/scalasteward/core/application/Context.scala	71.87% <0.00%> (-5.72%)	⬇️
...rc/main/scala/org/scalasteward/core/util/uri.scala	100.00% <0.00%> (ø)
...main/scala/org/scalasteward/core/data/SemVer.scala	100.00% <0.00%> (ø)
...main/scala/org/scalasteward/core/vcs/VCSType.scala	100.00% <0.00%> (ø)
...ain/scala/org/scalasteward/core/util/package.scala	100.00% <0.00%> (ø)
...scala/org/scalasteward/core/scalafmt/package.scala	100.00% <0.00%> (ø)
...ala/org/scalasteward/core/nurture/NurtureAlg.scala	0.00% <0.00%> (ø)
...ala/org/scalasteward/core/vcs/bitbucket/json.scala	92.85% <0.00%> (ø)
...la/org/scalasteward/core/repocache/RepoCache.scala	100.00% <0.00%> (ø)
...g/scalasteward/core/application/SelfCheckAlg.scala	100.00% <0.00%> (ø)
... and 16 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31fd96e...0e26153. Read the comment docs.

[fthomas]

We got the Codecov report now. \o/ @pjfanning is with: root_dir: ./modules still required?

[pjfanning]

@fthomas I removed the root-dir setting and codecov picks up the results nonetheless

[fthomas]

Great, thank you @pjfanning!