Set default --refresh-backoff-period to zero
#2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the default `--refresh-backoff-period` to 0 days which means that Scala Steward will not skip repos where running the build failed previously. It effectively disables the `RefreshErrorAlg`. I think this is a better default for most Scala Steward users since most have control over the repositories that Scala Steward tracks and can fix any issues with failing repos. Skipping repos is mostly interesting for public instances where the Scala Steward operator cannot fix all issues.
Codecov Report
@@ Coverage Diff @@
## master #2323 +/- ##
=======================================
Coverage 78.45% 78.45%
=======================================
Files 136 136
Lines 2349 2349
Branches 58 58
=======================================
Hits 1843 1843
Misses 506 506
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the default
--refresh-backoff-periodto 0 days which meansthat Scala Steward will not skip repos where running the build failed
previously. It effectively disables the
RefreshErrorAlg. Ithink this is a better default for most Scala Steward users since most
have control over the repositories that Scala Steward tracks and can fix
any issues with failing repos. Skipping repos is mostly interesting for
public instances where the Scala Steward operator cannot fix all issues.