Support reading a default repo config from this repository #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2337 +/- ##
==========================================
+ Coverage 79.71% 80.19% +0.48%
==========================================
Files 137 138 +1
Lines 2406 2404 -2
Branches 56 57 +1
==========================================
+ Hits 1918 1928 +10
+ Misses 488 476 -12
Continue to review full report at Codecov.
|
fthomas
changed the title
fthomas
changed the title
fthomas
commented
Nov 10, 2021
fthomas
commented
Nov 10, 2021
|
Is there a way to disable fetching default configuration from github? With on-prem & firewall rules new version can't be run |
|
@eugeniyk Yes, with |
|
ah ok, thanks! |
rtyley
added a commit
to rtyley/scala-steward
that referenced
this pull request
Feb 14, 2024
We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional? guardian/play-secret-rotation#432 See also scala-steward-org#2337 & scala-steward-org#1104
mzuehlke
pushed a commit
that referenced
this pull request
Feb 14, 2024
We're already seeing Scala Steward raise PRs for Scala 3.4.0, this might be unintentional? guardian/play-secret-rotation#432 See also #2337 & #1104
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for reading a defaultl repo config from this repository. Multiple repo configs can be loaded per Scala Steward installation with the
--repo-configcommand-line option and are merged into one effective global repo config. Loading the default repo config from this repository can be disabled with--disable-default-repo-config. This is similar to the handling of Scalafix and artifact migrations config files.The purpose of this change is to allow library maintainers to tell Scala Steward to ignore updates until a new version is announced (#1104). They can do this by adding new entries to the
updates.ignorelist of the default repo config. All (public and private) Scala Steward installations that do not opt-out of loading the default repo config will then ignore the added updates until the default repo config is changed again.The default repo config also contains ignored updates that were previously removed by
FilterAlg.removeBadVersions. So this function was just a defaultupdates.ignorelist in disguise.Note also that this is a breaking change for users that are using the old
--default-repo-confoption.--repo-configis a drop-in replacement for that option.