Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Resource for temporarily creating and removing files #2351

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Nov 14, 2021

Using Resource makes it easier to compose those functions compared to
nesting F[A] => F[A].

Using `Resource` makes it easier to compose those functions compared to
nesting `F[A] => F[A]`.
@fthomas fthomas added this to the 0.14.0 milestone Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #2351 (1de2281) into master (c0a00ab) will decrease coverage by 0.09%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2351      +/-   ##
==========================================
- Coverage   80.25%   80.16%   -0.10%     
==========================================
  Files         138      138              
  Lines        2391     2374      -17     
  Branches       60       55       -5     
==========================================
- Hits         1919     1903      -16     
+ Misses        472      471       -1     
Impacted Files Coverage Δ
...g/scalasteward/core/buildtool/maven/MavenAlg.scala 87.50% <66.66%> (ø)
...a/org/scalasteward/core/buildtool/sbt/SbtAlg.scala 97.29% <88.88%> (+1.29%) ⬆️
...org/scalasteward/core/application/StewardAlg.scala 40.00% <100.00%> (ø)
...org/scalasteward/core/buildtool/mill/MillAlg.scala 86.95% <100.00%> (ø)
.../main/scala/org/scalasteward/core/io/FileAlg.scala 96.66% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a00ab...1de2281. Read the comment docs.

@fthomas fthomas changed the title Use Resource for temporary creating and removing files Use Resource for temporarily creating and removing files Nov 14, 2021
@fthomas fthomas merged commit 0fcd5ee into master Nov 14, 2021
@fthomas fthomas deleted the topic/resource branch November 14, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant