Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework syntax for creating updates in tests #2377

Merged
merged 3 commits into from
Nov 26, 2021
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Nov 26, 2021

This reworks the syntax for creating updates in tests. It

  • does not use the Update.Single.apply and Update.Group.apply methods anymore. This will make it easier to change both classes since we need to update the apply method in a lot less places.
  • gets rid of implicit conversions in TestSyntax. The syntax is now based on extension methods via implicit classes only.
  • makes creating Updates more concise.

@fthomas fthomas added this to the 0.14.0 milestone Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #2377 (12783e6) into master (fd909aa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2377   +/-   ##
=======================================
  Coverage   80.42%   80.42%           
=======================================
  Files         139      139           
  Lines        2391     2391           
  Branches       51       51           
=======================================
  Hits         1923     1923           
  Misses        468      468           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd909aa...12783e6. Read the comment docs.

Copy link
Member

@mzuehlke mzuehlke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's easier to read 👍

@fthomas fthomas merged commit e5a8bd2 into master Nov 26, 2021
@fthomas fthomas deleted the topic/new-update-syntax-2 branch November 26, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants