Check runAfterUpgrading for formatting changed files
#2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks the `runAfterUpgrading` option before reformatting changed files after the version bump. Until now this option only controlled if scalafmt should be run on the whole project after a scalafmt update. I think it makes sense to use this option also here so that one can disable runnig scalafmt completely.
Codecov Report
@@ Coverage Diff @@
## master #2380 +/- ##
=======================================
Coverage 80.42% 80.43%
=======================================
Files 139 139
Lines 2391 2392 +1
Branches 51 44 -7
=======================================
+ Hits 1923 1924 +1
Misses 468 468
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks the
runAfterUpgradingoption before reformatting changedfiles after the version bump. Until now this option only controlled if
scalafmt should be run on the whole project after a scalafmt update.
I think it makes sense to use this option also here so that one can
disable runnig scalafmt completely.