Do not run scalafmt with --quiet
#2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This partially reverts #2321. The `--quiet` option also suppresses helpful error messages: ``` $ scalafmt --non-interactive --quiet $ scalafmt --non-interactive Invalid config: Default dialect is deprecated; use explicit: [sbt0137,sbt1,scala211,scala212,scala212source3,scala213,scala213source3,scala3] Also see https://scalameta.org/scalafmt/docs/configuration.html#scala-dialects" : ~/.scalafmt.conf ``` Which means we currently get unhelpful error messages like this: ``` [info] 2021-12-23 16:34:31,733 WARN Reformatting changed files failed [info] java.io.IOException: 'scalafmt --non-interactive --quiet --mode changed' exited with code 8 [info] at org.scalasteward.core.io.process$.$anonfun$slurp$9(process.scala:54) ``` With this change, the above exception will contain the message about the invalid config.
Codecov Report
@@ Coverage Diff @@
## master #2425 +/- ##
==========================================
- Coverage 80.96% 80.95% -0.01%
==========================================
Files 141 141
Lines 2443 2442 -1
Branches 54 57 +3
==========================================
- Hits 1978 1977 -1
Misses 465 465
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially reverts #2321.
The
--quietoption also suppresses helpful error messages:Which means we currently get unhelpful error messages like this:
With this change, the above exception will contain the message about the
invalid config.