check if the version of the migrated artifact exists #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2455 +/- ##
==========================================
+ Coverage 81.05% 81.17% +0.11%
==========================================
Files 142 142
Lines 2460 2475 +15
Branches 39 44 +5
==========================================
+ Hits 1994 2009 +15
Misses 466 466
Continue to review full report at Codecov.
|
|
👍 I haven't had time to look into this PR in detail yet but was wondering if we could get rid of |
… provided by coursier.
|
I like the the idea of removing |
fthomas
added a commit
that referenced
this pull request
Jan 22, 2022
This adds a new default file for artifacts migrations that does not contain the `initialVersion` fields. Since older Scala Steward instances load the list of artifact migrations from this repository, removing fields is a backward-incompatible change so that we cannot remove them in the old default file. See #2455 and #2472 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the version of the migrated artifact exists using the
versionCache. As now the version of the migrated artifact is detectedArtifactChange#initialVersionis no longer needed.fixes #2450
This should prevent problems like in #2447