Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sbt-java-formatter hook to default.scala-steward.conf #2495

Merged
merged 6 commits into from
Jul 4, 2022

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Jan 31, 2022

This also replaces variables in the commit message of post-update hooks.

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #2495 (d31f1dc) into main (ed02d87) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2495      +/-   ##
==========================================
+ Coverage   81.22%   81.31%   +0.08%     
==========================================
  Files         146      146              
  Lines        2594     2590       -4     
  Branches       52       42      -10     
==========================================
- Hits         2107     2106       -1     
+ Misses        487      484       -3     
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/edit/EditAlg.scala 94.59% <100.00%> (-0.15%) ⬇️
...rg/scalasteward/core/edit/hooks/HookExecutor.scala 94.20% <100.00%> (+3.17%) ⬆️
...in/scala/org/scalasteward/core/git/CommitMsg.scala 100.00% <100.00%> (ø)
...main/scala/org/scalasteward/core/git/package.scala 100.00% <100.00%> (ø)
...steward/core/repoconfig/PostUpdateHookConfig.scala 100.00% <100.00%> (ø)
...calasteward/core/vcs/data/NewPullRequestData.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed02d87...d31f1dc. Read the comment docs.

@fthomas fthomas marked this pull request as draft February 2, 2022 08:35
@exoego exoego added refactoring enhancement New feature or request and removed refactoring labels Jun 15, 2022
@fthomas fthomas marked this pull request as ready for review July 4, 2022 14:08
@fthomas fthomas merged commit 48e4332 into main Jul 4, 2022
@fthomas fthomas deleted the topic/move-sbt-java-formatter-hook branch July 4, 2022 17:31
@fthomas fthomas added this to the 0.15.0 milestone Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants