Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset update branch before merging the base branch #2504

Merged
merged 5 commits into from
Feb 5, 2022
Merged

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Feb 3, 2022

Closes #2503.

@fthomas fthomas added the enhancement New feature or request label Feb 3, 2022
@fthomas fthomas added this to the 0.15.0 milestone Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #2504 (fb5b72f) into main (0620824) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2504   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files         142      142           
  Lines        2500     2511   +11     
  Branches       55       50    -5     
=======================================
+ Hits         2029     2038    +9     
- Misses        471      473    +2     
Impacted Files Coverage Δ
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% <0.00%> (ø)
...n/scala/org/scalasteward/core/git/FileGitAlg.scala 98.52% <100.00%> (+0.19%) ⬆️
...in/scala/org/scalasteward/core/git/GenGitAlg.scala 93.10% <100.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0620824...fb5b72f. Read the comment docs.

@fthomas
Copy link
Member Author

fthomas commented Feb 5, 2022

This change can be seen in action in scala-steward-org/test-repo-2#87 and scala-steward-org/test-repo-2#127.

@fthomas fthomas merged commit 88024c7 into main Feb 5, 2022
@fthomas fthomas deleted the topic/resetBranch branch February 6, 2022 18:46
@nafg
Copy link
Contributor

nafg commented Oct 23, 2022

This seems to result in PRs accruing lots of revert commits.

Instead why not recreate the branch from scratch? Why not git rest to the base branch and force push?

@nafg
Copy link
Contributor

nafg commented Oct 23, 2022

slick/slick#2511 got to nineteen commits by the time Mergify merged it!!!

@nafg
Copy link
Contributor

nafg commented Nov 23, 2022

This is really bad, any chance of reverting it?

@fthomas
Copy link
Member Author

fthomas commented Nov 24, 2022

This is really bad

I find your tone rude. Please be more constructive in future interactions in this project.

@nafg
Copy link
Contributor

nafg commented Nov 28, 2022

Apologies, I did not mean it in that way.

Where do we go from here? slick/slick#2491 now has 43 commits.

@exoego
Copy link
Contributor

exoego commented Nov 28, 2022

Please open a new issue to collect feedback from community.
PR is also welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updated PRs could be broken after merge
3 participants