-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt the check for hashes in versions #2522
Conversation
From checking if the complete version value is a hash to only checking if it contains a hash (at least 8 characters long). The hash component detected by the parser only requires 6 byte, but in addition some leading separator.
Codecov Report
@@ Coverage Diff @@
## main #2522 +/- ##
==========================================
+ Coverage 81.01% 81.09% +0.08%
==========================================
Files 143 143
Lines 2518 2534 +16
Branches 46 51 +5
==========================================
+ Hits 2040 2055 +15
- Misses 478 479 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modules/core/src/main/scala/org/scalasteward/core/data/Version.scala
Outdated
Show resolved
Hide resolved
The fun isn't over yet: davegurnell/unindent#69 :-) |
This is an update from a version with a hash to another version with a hash. |
Maybe we should just ignore versions that start with a hash. A bump like |
From checking if the complete version value is a hash to only checking if it contains a hash (at least 8 characters long).
The hash component detected by the parser only requires 6 byte, but in addition some leading separator.
Fixes #2502
Improves predecessor #2498
Original issue #2483