Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sttp 3.6.1 artifact migrations #2598

Merged
merged 1 commit into from
May 12, 2022
Merged

Add sttp 3.6.1 artifact migrations #2598

merged 1 commit into from
May 12, 2022

Conversation

hugo-vrijswijk
Copy link
Contributor

@hugo-vrijswijk hugo-vrijswijk commented May 9, 2022

In sttp 3.6.1 some artifacts are no longer published as they're included in their respective 'core' modules (httpclient-backend-fs2fs2). Example of the rename that needs to be done: https://github.com/stryker-mutator/stryker4s/pull/1154/files

This PR adds artifact migrations for the changed modules.

I haven't found a setting for what version the artifact is migrated, so I assume scala-steward uses the latest version when upgrading?

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #2598 (0c151d0) into main (d44ce02) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2598   +/-   ##
=======================================
  Coverage   81.08%   81.08%           
=======================================
  Files         144      144           
  Lines        2538     2538           
  Branches       46       46           
=======================================
  Hits         2058     2058           
  Misses        480      480           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d44ce02...0c151d0. Read the comment docs.

@hugo-vrijswijk
Copy link
Contributor Author

@fthomas could you have a look at this 🙏?

@mzuehlke mzuehlke merged commit c2be23f into scala-steward-org:main May 12, 2022
@hugo-vrijswijk hugo-vrijswijk deleted the sttp-artifact-rename branch May 12, 2022 15:17
@fthomas fthomas added this to the 0.15.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants