Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plural pullRequests in dependencyOverrides config suggestion #2610

Merged
merged 2 commits into from
May 20, 2022

Conversation

samspills
Copy link
Contributor

When scala-steward opens PRs it includes a little snippet to explain how to override the dependency config, and the suggestion looks like this

dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "com.blerf.dependency", artifactId = "dependency-client" }
}]

I tried to use this suggestion and got a parse error:

Attempt to decode value on failed cursor: DownField(pullRequests),DownArray,DownField(dependencyOverrides)

This PR updates pullRequest (singular) to pullRequests (plural)

@exoego
Copy link
Contributor

exoego commented May 20, 2022

@exoego
Copy link
Contributor

exoego commented May 20, 2022

@samspills Could you also update the tests?

@samspills
Copy link
Contributor Author

@exoego Just updated them!

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2610 (075fbbf) into main (bae7271) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2610   +/-   ##
=======================================
  Coverage   81.10%   81.10%           
=======================================
  Files         144      144           
  Lines        2540     2540           
  Branches       48       48           
=======================================
  Hits         2060     2060           
  Misses        480      480           
Impacted Files Coverage Δ
...scalasteward/core/repoconfig/GroupRepoConfig.scala 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae7271...075fbbf. Read the comment docs.

@exoego exoego merged commit 6c8cac7 into scala-steward-org:main May 20, 2022
@fthomas fthomas added the bug Something isn't working label Jun 2, 2022
@fthomas fthomas added this to the 0.15.0 milestone Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants