Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore common prefix weight for snapshots ordering #2707

Merged

Conversation

arixmkii
Copy link
Contributor

@arixmkii arixmkii commented Sep 6, 2022

This is a bug fix to match the documented behavior in #2635

This also implies, that it will be allowed for snapshot versions to be updated to snapshots of different series.

For this to work reliably we need to eliminate weight of common prefix in allowPrereleases mode upgrading from Snapshot to Snapshot.

This is crucial, because in many projects (which publishes only snapshots for some reasons like continuous builds) there is no point to merge snapshots one by one sequentially.

Tests for these cases added.

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #2707 (ccf9a68) into main (590f136) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2707      +/-   ##
==========================================
+ Coverage   80.68%   80.69%   +0.01%     
==========================================
  Files         146      146              
  Lines        2676     2678       +2     
  Branches       46       48       +2     
==========================================
+ Hits         2159     2161       +2     
  Misses        517      517              
Impacted Files Coverage Δ
...ain/scala/org/scalasteward/core/data/Version.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoego exoego merged commit 7e312bd into scala-steward-org:main Sep 6, 2022
@exoego exoego added this to the 0.16.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants