Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow --url-checker-test-url option multiple times #2762

Merged
merged 2 commits into from
Nov 18, 2022

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Nov 11, 2022

This allows the --url-checker-test-url option to be used multiple times. Each argument of this option is checked with the UrlChecker in SelfCheckAlg at program start-up.

This is useful when Scala Steward is used in corporate environments where one wants to ensure that it can check internal and externals URLs.

This allows the `--url-checker-test-url` option to be used multiple
times. Each argument of this option is checked with the `UrlChecker`
in `SelfCheckAlg` at program start-up.

This is useful when Scala Steward is used in corporate environments
where one wants to ensure that it can check internal and externals
URLs.
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Base: 80.51% // Head: 80.48% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (581f457) compared to base (d1fd2da).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   80.51%   80.48%   -0.03%     
==========================================
  Files         149      149              
  Lines        2853     2849       -4     
  Branches      192      189       -3     
==========================================
- Hits         2297     2293       -4     
  Misses        556      556              
Impacted Files Coverage Δ
...ala/org/scalasteward/core/application/Config.scala 100.00% <ø> (ø)
.../scala/org/scalasteward/core/application/Cli.scala 100.00% <100.00%> (ø)
...g/scalasteward/core/application/SelfCheckAlg.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoego exoego merged commit 39dd8db into main Nov 18, 2022
@exoego exoego added the enhancement New feature or request label Nov 18, 2022
@exoego exoego deleted the topic/allow-multiple-url-checker-test-urls branch November 18, 2022 01:47
@exoego exoego added this to the 0.16.0 milestone Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants