Add scala-collection-compact Scalafile rule when bump from 2.12 to 2.13

[alifirat]

Address #2770

I'm not sure if my rule is too specific to the scala-compact-library and should be more general to the scala bumping version.

[codecov]

Codecov Report

Base: 80.69% // Head: 80.69% // No change to project coverage 👍

Coverage data is based on head (3a83ab1) compared to base (f1b1631).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2799   +/-   ##
=======================================
  Coverage   80.69%   80.69%           
=======================================
  Files         149      149           
  Lines        2865     2865           
  Branches      215      215           
=======================================
  Hits         2312     2312           
  Misses        553      553           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[alejandrohdezma]

question (blocking): Shouldn't this be run when updating Scala itself (instead of scala-collection-compat)?

_{This comment follows the conventionalcomments.org standard}

[alifirat]

That was my remark: I have the feeling that the rule is too specific to the collection itself while it should be more oriented to the scala version.
In this case, what should be the value of newVersion ? "2.13.0" or we case use a expression like 'newVersion = 2.13. ' to match any update to Scala 2.13 ?

[alejandrohdezma]

Yeah, I believe this should be:

  {
    groupId: "org.scala-lang",
    artifactIds: ["scala-library", "scala-compiler", "scala-reflect", "scalap"],
    newVersion: "2.13.0",
    doc: "https://github.com/scala/scala-collection-compat#collection213upgrade",
    rewriteRules: ["dependency:Collection213Upgrade@org.scala-lang.modules:scala-collection-migrations:2.8.1"]
  },

[alejandrohdezma]

WDYT @exoego?

[fthomas]

Yeah, I think this makes more sense.

The docs of that rewrite also mention that this Scalafix requires scalacOptions: ["-P:semanticdb:synthetics:on"].

In this case, what should be the value of newVersion ? "2.13.0" or we case use a expression like 'newVersion = 2.13. ' to match any update to Scala 2.13 ?

2.13.0 is fine because Scala Steward will use that the rule when it updates from a version < 2.13.0 to a version >= 2.13.0.

[alifirat]

Then, if we all agree I can update the PR with your feedbacks?

[alifirat]

@fthomas @alejandrohdezma thanks for the feedback, I've rebased and updated the PR.
Tell me if it's good to you.

[EwoutH]

Thanks a lot for this! Any way that I can test it before the next release is tagged?

[alejandrohdezma]

If you are using the scala-steward-action you can set the scala-version input to 0.16.1-2-2a5efcc4-SNAPSHOT

[fthomas]

You don't need to use the latest Scala Steward version to test this. Scalafix migrations are available to all Scala Steward instances as soon as they are merged here (unless that is disabled by the --disable-default-scalafix-migrations command-line option).

[EwoutH]

Thank you both!