-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug on Update
JSON encoders
#2805
Conversation
Codecov ReportBase: 80.59% // Head: 80.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
==========================================
+ Coverage 80.59% 80.69% +0.10%
==========================================
Files 149 149
Lines 2860 2865 +5
Branches 200 215 +15
==========================================
+ Hits 2305 2312 +7
+ Misses 555 553 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. β View full report at Codecov. |
hey @alejandrohdezma do you plan to publish a patch version soon? |
@alejandrohdezma didn't think about it but if there is a snapshot version available, I can give a try and share feedbacks about the patch. |
Yeah! It should be |
No objection to releasing 0.16.1 from me. |
@alejandrohdezma after cleaning the workspace, it worked as expected. |
Releasing |
Version |
π The bug
Update
decoders are expecting JSON objects to be wrapped in a field named as the class:While individual encoders are not creating this field.
This only happens when decoding
Grouped
updates, since it is the only place an individual encoder was being used.π¨πΌβπ» The solution
This PR ensures encoders always introduce this wrapper-field so updates are correctly parsed on every situation.
References
Fixes #2802