Fail on --vcs-* options

[fthomas]

This makes --vcs-* options unusable. If they are used, Scala Steward will print a message and exit with an error.

These options are deprecated since #2916 and should be replaced with the corresponding --forge-* options.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b6162bc) 91.06% compared to head (b7ef418) 91.07%.
Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3241   +/-   ##
=======================================
  Coverage   91.06%   91.07%           
=======================================
  Files         163      163           
  Lines        3391     3394    +3     
  Branches      309      300    -9     
=======================================
+ Hits         3088     3091    +3     
  Misses        303      303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[fthomas]

Heads-up @tgodzik: Is the public Scala Steward instance already using the --forge-* options instead of --vcs-*? If not, it will stop working once this PR is merged.

[exoego]

To not surprise users in winter holiday, let's merge this in 2024 January or later.

[fthomas]

Sounds good to me.

[tgodzik]

Heads-up @tgodzik: Is the public Scala Steward instance already using the --forge-* options instead of --vcs-*? If not, it will stop working once this PR is merged.

Thanks for the heads up! I updated it and deployed the new config.

[fthomas]

My plan is to merge this on 2024-01-22 and maybe also release 0.29.0 then.

[rtyley]

Just to note that the minimum necessary version of scala-steward-action (if you're using it) after this PR is v2.62.0 - otherwise the run will fail, and you'll see error messages like these:

Error: --vcs-api-host is deprecated; use --forge-api-host instead
Error: --vcs-login is deprecated; use --forge-login instead

Curiously, although I can see that #2916 introduced deprecation of the old CLI options back in January 2023, along with updates to the Markdown doc, I haven't been seeing the deprecation warnings appear in the actual Scala Steward runs themselves, eg this recent run doesn't contain the string 'deprecated in favor of'.

[fthomas]

I haven't been seeing the deprecation warnings appear in the actual Scala Steward runs themselves, eg this recent run doesn't contain the string 'deprecated in favor of'.

That string was only visible in the help message of the command-line options. Scala Steward did not log a warning if that option was used after #2916. It would have been nice if it had done that.

[rtyley]

Ah ok! No worries!