add migration for bucket4j #3433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnhoekstra
force-pushed
the
rename-bucket4j
branch
from
7337686 to
c20a1d8
Compare
mzuehlke
requested changes
Oct 10, 2024
Comment on lines
1408
to
1409
| groupIdBefore = com.bucket4j | ||
| groupIdAfter = com.bucket4j |
There was a problem hiding this comment.
If the groupId isn't changing is is enough to just specify groupIdAfter.
You will find such examples in the file.
There was a problem hiding this comment.
nice, I removed the groupIdBefore's
martijnhoekstra
force-pushed
the
rename-bucket4j
branch
from
d2d2ec2 to
3b72f41
Compare
mzuehlke
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bucket4j went for a versioning and deployment scheme split in 8+, 11+ and 17+. I moved to 17+ as that should be the most common, and the scalasteward user should now at least be notified of the option to update, allowing to override to a different one if wanted.