Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration rule for (not yet released) scalacheck 1.14.1 #853

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

smarter
Copy link
Contributor

@smarter smarter commented Aug 20, 2019

@smarter smarter force-pushed the scalacheck-migration branch from ed28a1b to 88f7f4b Compare August 20, 2019 18:18
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #853 into master will increase coverage by 0.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   66.95%   67.08%   +0.13%     
==========================================
  Files          88       88              
  Lines        1256     1261       +5     
  Branches       42       39       -3     
==========================================
+ Hits          841      846       +5     
  Misses        415      415
Impacted Files Coverage Δ
...scala/org/scalasteward/core/scalafix/package.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92e1d5...88f7f4b. Read the comment docs.

@smarter smarter mentioned this pull request Aug 20, 2019
12 tasks
Copy link
Member

@fthomas fthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @smarter!

@fthomas fthomas merged commit 5a947e3 into scala-steward-org:master Aug 20, 2019
@fthomas fthomas added this to the 0.4.0 milestone Aug 20, 2019
@fthomas
Copy link
Member

fthomas commented Sep 18, 2019

FYI: Scala Steward PRs with this migration applied can be found via:
https://github.com/pulls?q=author%3Ascala-steward+is%3Apr+%22github%3Atypelevel%2Fscalacheck%2Fv1_14_1%3Fsha%3D3fc537dde9d8fdf951503a8d8b027a568d52d055%22

It is still creating new PRs for ScalaCheck 1.14.1. When it is done, I'll list here the PRs that contain source code changes due to this migration.

@fthomas
Copy link
Member

fthomas commented Oct 7, 2019

Until now Scala Steward has created 179 public PRs with this migration applied. Six of those also contain source code changes due to the migration:

At $WORK we are using Scala Steward for three private repos and also got one PR with source code changes. So I assume some more with source code changes were created by other private Scala Steward instances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants