Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: accessing protected field in nested trait crashes in erasure #6245

Closed
scabug opened this issue Aug 15, 2012 · 13 comments
Closed

regression: accessing protected field in nested trait crashes in erasure #6245

scabug opened this issue Aug 15, 2012 · 13 comments
Assignees
@namin
Labels
java interop regression
Milestone
2.9.3-RC1

Comments

@scabug
Copy link

scabug commented Aug 15, 2012

Yet another bug with protected access. Stopped working in M3.

t1/Base.java

package t1;

public class Base {
  protected Vis inner;
}

t1/Vis.java

package t1;

public class Vis { }

Foo.scala

import t1.Vis

abstract class Foo extends t1.Base {
  trait Nested {
    def crash() {
      inner
    }
  }
}

Changing trait to class fixes the problem.

Crash:

exception when typing Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner()/class scala.reflect.internal.Trees$Apply
t1.Vis does not take parameters in file erasureCrash.scala
scala.reflect.internal.Types$TypeError: t1.Vis does not take parameters
	at scala.tools.nsc.typechecker.Contexts$Context.issueCommon(Contexts.scala:369)
	at scala.tools.nsc.typechecker.Contexts$Context.issue(Contexts.scala:373)
	at scala.tools.nsc.typechecker.Infer$Inferencer.issue(Infer.scala:281)
	at scala.tools.nsc.typechecker.Typers$Typer.scala$tools$nsc$typechecker$Typers$Typer$$duplErrorTree$1(Typers.scala:2879)
	at scala.tools.nsc.typechecker.Typers$Typer.doTypedApply(Typers.scala:3165)
	at scala.tools.nsc.typechecker.Typers$Typer.typedApply$1(Typers.scala:4336)
	at scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:5114)
	at scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:756)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5285)
	at scala.tools.nsc.typechecker.Typers$Typer.scala$tools$nsc$typechecker$Typers$Typer$$typedStat$1(Typers.scala:2690)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54$$anonfun$55.apply(Typers.scala:2786)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54$$anonfun$55.apply(Typers.scala:2786)
	at scala.collection.immutable.List.loop$1(List.scala:164)
	at scala.collection.immutable.List.mapConserve(List.scala:180)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54.apply(Typers.scala:2786)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54.apply(Typers.scala:2785)
	at scala.tools.nsc.typechecker.Typers$Typer.withSavedContext(Typers.scala:523)
	at scala.tools.nsc.typechecker.Typers$Typer.typedStats(Typers.scala:2785)


....

	at scala.collection.Iterator$class.foreach(Iterator.scala:726)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1155)
	at scala.tools.nsc.Global$GlobalPhase.run(Global.scala:426)
	at scala.tools.nsc.Global$Run.compileUnitsInternal(Global.scala:1576)
	at scala.tools.nsc.Global$Run.compileUnits(Global.scala:1550)
	at scala.tools.nsc.Global$Run.compileSources(Global.scala:1546)
	at scala.tools.nsc.Global$Run.compile(Global.scala:1656)
	at scala.tools.nsc.Driver.doCompile(Driver.scala:33)
	at scala.tools.nsc.Main$.doCompile(Main.scala:79)
	at scala.tools.nsc.Driver.process(Driver.scala:54)
	at scala.tools.nsc.Driver.main(Driver.scala:67)
	at scala.tools.nsc.Main.main(Main.scala)
error: unrecoverable error
exception when typing {
  Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner();
  ()
}
exception when typing def crash(): Unit = {
  Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner();
  ()
}
exception when typing abstract trait Nested$class extends Object with Foo#Nested {
  def /*Nested$class*/$init$(): Unit = {
    ()
  };
  def crash(): Unit = {
    Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner();
    ()
  }
}
exception when typing abstract class Foo extends t1.Base {
  final <superaccessor> def Foo$$super$inner(): t1.Vis;
  def <init>(): Foo = {
    Foo.super.<init>();
    ()
  };
  abstract trait Nested extends Object {
    def crash(): Unit;
    <synthetic> <stable> def Foo$Nested$$$outer(): Foo
  };
  abstract trait Nested$class extends Object with Foo#Nested {
    def /*Nested$class*/$init$(): Unit = {
      ()
    };
    def crash(): Unit = {
      Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner();
      ()
    }
  }
}
exception when typing package <empty> {
  abstract class Foo extends t1.Base {
    final <superaccessor> def Foo$$super$inner(): t1.Vis;
    def <init>(): Foo = {
      Foo.super.<init>();
      ()
    };
    abstract trait Nested extends Object {
      def crash(): Unit;
      <synthetic> <stable> def Foo$Nested$$$outer(): Foo
    };
    abstract trait Nested$class extends Object with Foo#Nested {
      def /*Nested$class*/$init$(): Unit = {
        ()
      };
      def crash(): Unit = {
        Nested$class.this.Foo$Nested$$$outer().Foo$$super$inner();
        ()
      }
    }
  }
}

     while compiling: erasureCrash.scala
        during phase: erasure
     library version: version 2.10.0-20120808-025545-a80b538763
    compiler version: version 2.10.0-20120813-143144-6b733b3596
  reconstructed args: -classpath bin

  last tree to typer: This(trait Nested)
              symbol: trait Nested in class Foo (flags: <interface> abstract <trait> <lateinterface>)
   symbol definition: abstract trait Nested extends Object
       symbol owners: trait Nested -> class Foo -> package <empty>
      context owners: method crash -> class Nested$class -> class Foo -> package <empty>

== Enclosing template or block ==

Apply( // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=Foo
  Nested$class.this."Foo$Nested$$$outer" // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=()Foo
  Nil
)

unhandled exception while transforming erasureCrash.scala
error: 
     while compiling: erasureCrash.scala
        during phase: erasure
     library version: version 2.10.0-20120808-025545-a80b538763
    compiler version: version 2.10.0-20120813-143144-6b733b3596
  reconstructed args: -classpath bin

  last tree to typer: This(trait Nested)
              symbol: trait Nested in class Foo (flags: <interface> abstract <trait> <lateinterface>)
   symbol definition: abstract trait Nested extends Object
       symbol owners: trait Nested -> class Foo -> package <empty>
      context owners: method crash -> class Nested$class -> class Foo -> package <empty>

== Enclosing template or block ==

Apply( // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=Foo
  Nested$class.this."Foo$Nested$$$outer" // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=()Foo
  Nil
)

uncaught exception during compilation: scala.reflect.internal.FatalError
error: scala.reflect.internal.FatalError: 
     while compiling: erasureCrash.scala
        during phase: global=erasure, atPhase=posterasure
     library version: version 2.10.0-20120808-025545-a80b538763
    compiler version: version 2.10.0-20120813-143144-6b733b3596
  reconstructed args: -classpath bin

  last tree to typer: This(trait Nested)
              symbol: trait Nested in class Foo (flags: <interface> abstract <trait> <lateinterface>)
   symbol definition: abstract trait Nested extends Object
       symbol owners: trait Nested -> class Foo -> package <empty>
      context owners: method crash -> class Nested$class -> class Foo -> package <empty>

== Enclosing template or block ==

Apply( // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=Foo
  Nested$class.this."Foo$Nested$$$outer" // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=()Foo
  Nil
)

unrecoverable error
	at scala.reflect.internal.SymbolTable.abort(SymbolTable.scala:46)
	at scala.tools.nsc.Global.abort(Global.scala:250)
	at scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:763)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5285)
	at scala.tools.nsc.typechecker.Typers$Typer.scala$tools$nsc$typechecker$Typers$Typer$$typedStat$1(Typers.scala:2690)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54$$anonfun$55.apply(Typers.scala:2786)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54$$anonfun$55.apply(Typers.scala:2786)
	at scala.collection.immutable.List.loop$1(List.scala:164)
	at scala.collection.immutable.List.mapConserve(List.scala:180)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54.apply(Typers.scala:2786)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$54.apply(Typers.scala:2785)
	at scala.tools.nsc.typechecker.Typers$Typer.withSavedContext(Typers.scala:523)
	at scala.tools.nsc.typechecker.Typers$Typer.typedStats(Typers.scala:2785)
	at scala.tools.nsc.typechecker.Typers$Typer.typedBlock(Typers.scala:2249)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$typed1$3.apply(Typers.scala:4946)
	at scala.tools.nsc.typechecker.Typers$Typer$$anonfun$typed1$3.apply(Typers.scala:4946)
	at scala.tools.nsc.typechecker.Typers$Typer.typerWithLocalContext(Typers.scala:506)
	at scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:4945)
	at scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:756)
	at scala.tools.nsc.typechecker.Typers$Typer.typed(Typers.scala:5285)
	at scala.tools.nsc.typechecker.Typers$Typer.transformedOrTyped(Typers.scala:5484)
	at scala.tools.nsc.typechecker.Typers$Typer.typedDefDef(Typers.scala:2078)
	at scala.tools.nsc.typechecker.Typers$Typer.typed1(Typers.scala:4914)
	at scala.tools.nsc.transform.Erasure$Eraser.typed1(Erasure.scala:756)

...


	at scala.tools.nsc.Driver.process(Driver.scala:54)
	at scala.tools.nsc.Driver.main(Driver.scala:67)
	at scala.tools.nsc.Main.main(Main.scala)

error: fatal error: 
     while compiling: erasureCrash.scala
        during phase: global=erasure, atPhase=posterasure
     library version: version 2.10.0-20120808-025545-a80b538763
    compiler version: version 2.10.0-20120813-143144-6b733b3596
  reconstructed args: -classpath bin

  last tree to typer: This(trait Nested)
              symbol: trait Nested in class Foo (flags: <interface> abstract <trait> <lateinterface>)
   symbol definition: abstract trait Nested extends Object
       symbol owners: trait Nested -> class Foo -> package <empty>
      context owners: method crash -> class Nested$class -> class Foo -> package <empty>

== Enclosing template or block ==

Apply( // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=Foo
  Nested$class.this."Foo$Nested$$$outer" // val Foo$Nested$$$outer(): Foo in trait Nested, tree.tpe=()Foo
  Nil
)

unrecoverable error
@scabug
Copy link
Author

scabug commented Aug 15, 2012

Imported From: https://issues.scala-lang.org/browse/SI-6245?orig=1
Reporter: @hubertp
Affected Versions: 2.10.0-M3
Other Milestones: 2.10.0-M7, 2.10.0

@scabug
Copy link
Author

scabug commented Aug 17, 2012

@hubertp said:
Caused by: f708b87e559a6402205c9c9d8

@scabug
Copy link
Author

scabug commented Aug 28, 2012

@heathermiller said:
This is an excellent counterexample for commit scala/scala@f708b87e559a6402205c9c9d8

@scabug
Copy link
Author

scabug commented Aug 28, 2012

@paulp said:
scala/scala#1205

@scabug
Copy link
Author

scabug commented Sep 7, 2012

@odersky said:
@jsuereth I think our best course of action is to revert the commit
scala/scala@f708b87e559a6402205c9c9d8

This is really tricky stuff. We should not make untested changes days before an RC.

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@gkossakowski said:
Nada expressed interest in looking into this to either revert the faulty commit or improve it so both #6245 and #2296 are fixed.

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@hubertp said:
I missed that the build failed... I think we should still try to fix both of them as they are a real pain when you are dealing with external Java libraries (rather than reverting the initial commit).

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@paulp said:
I believe to fix both requires generating the accessor in such a way that it will work as both a superaccessor and a protected accessor. Or generating both of them. I have some work in progress trying to sort it out - no guarantees about anything in this code, but it might be useful to look at.

https://github.com/paulp/scala/tree/issue/6245

I think it will be tricky, but I'd say take a shot at it (not that my opinion is overly relevant.)

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@namin said:
Thanks, Paul; I will definitely take a look.

For the shorter time, would it make sense to generate a compile-time error for #2296 while fixing this regression? I have a small change in this direction:

https://github.com/namin/scala/tree/si-6245

What do you think?

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@paulp said:
Other than that you should use string interpolation on the error message, looks sensible to me.

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@namin said:
I actually realized that isJavaProtected doesn't need to report an error. t2296 tests still run fine! Not sure if there are other counterexamples lurking but this branch fixed this regression while maintaining the fix for #2296:

https://github.com/namin/scala/tree/super

Thoughts?

@scabug
Copy link
Author

scabug commented Sep 11, 2012

@paulp said:
That's entirely believable; it shouldn't be hard to keep one or the other working, it's both which may be elusive.

@scabug
Copy link
Author

scabug commented Sep 17, 2012

@gkossakowski said:
Fixed in:
scala/scala#1299
scala/scala#1323

@scabug scabug closed this as completed Sep 17, 2012
@scabug scabug added this to the 2.9.3-RC1 milestone Apr 7, 2017
@scabug scabug mentioned this issue Apr 7, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@namin namin

Labels
java interop regression
Projects
None yet
Milestone
2.9.3-RC1
Development

No branches or pull requests
2 participants
@namin @scabug