Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typelevel/cats to build #363

Closed
adelbertc opened this issue Oct 24, 2016 · 5 comments
Closed

Add typelevel/cats to build #363

adelbertc opened this issue Oct 24, 2016 · 5 comments
Assignees
@SethTisue

Comments

@adelbertc
Copy link
Contributor

adelbertc commented Oct 24, 2016 •
edited
Loading

May be blocked on #13 for cats-laws

Currently the build is tracking @SethTisue 's fork. Once typelevel/cats#1415 is merged we should be able to point back to typelevel/cats and run it against all of catsJVM (instead of just core and macros).
@SethTisue
Copy link
Member

SethTisue commented Oct 25, 2016 •
edited
Loading

1415 is now merged and in #367 I brought my fork up to date with that

in order to get rid of the fork, typelevel/cats#1396 would need to be fixed in the cats repo — right now we are working around it in my fork with SethTisue/cats@04c921f

@adelbertc
Copy link
Contributor Author

@SethTisue Coincidentally I was just working on a PR for you typelevel/cats#1426 :-)

adelbertc added a commit to adelbertc/community-builds that referenced this issue Oct 25, 2016
@adelbertc
Track typelevel/cats instead of fork - fixes scala#363
4ccd026
@adelbertc
Copy link
Contributor Author

adelbertc commented Oct 25, 2016 •
edited
Loading

@SethTisue Present for you:

#369

(typelevel/cats#1426 is merged)

@SethTisue SethTisue self-assigned this Oct 25, 2016
@SethTisue SethTisue removed their assignment Nov 9, 2016
@SethTisue SethTisue mentioned this issue Nov 28, 2016
Closed
@SethTisue
Copy link
Member

SethTisue commented Jan 4, 2017 •
edited
Loading

#448 removes a roadblock and adds cats-laws

#375 is the new #369

@SethTisue SethTisue self-assigned this Jan 5, 2017
@adelbertc
Copy link
Contributor Author

Fixed by #375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SethTisue @adelbertc