Add spire and discipline projects #24
Conversation
It's a dependency of spire so we would like to give it a warm welcome in dbuild-covered family of projects!
It almost builds completely with Scala 2.11. The one subproject that crashes the compiler is "tests". It fails due to https://issues.scala-lang.org/browse/SI-8425.
|
Review by @retronym |
| uri: "https://github.com/"${vars.spire-ref} | ||
| extra: { | ||
| // all except "tests" subproject that crashes due to https://issues.scala-lang.org/browse/SI-8425 | ||
| projects: ["core", "benchmark", "examples", "macros", "scalacheck-binding"] |
There was a problem hiding this comment.
The fix is merged, lets build it all now.
| @@ -80,6 +80,8 @@ vars: { | |||
| // https://github.com/valotrading/zeromq-scala-binding/commit/c2a8a87673a1a3468486d1af9a6460bfed25c7a2 | |||
| // therefore (which has a broken libdep of scalatest, however (cross full)): | |||
| zeromq-scala-binding-ref : "valotrading/zeromq-scala-binding.git#062e9438e322ec29d75b9649cb2aafa6ba3198a6" | |||
| // fixed sha/tag (a compromise), the sha points at master that does support Scala 2.11 | |||
There was a problem hiding this comment.
Just FYI: "that supports" would be idiomatic English here, unless you are really emphasising the "does" part ("Unlike X, Y really does support Z")
There was a problem hiding this comment.
Thanks. :-)
Yes, I'm aware of implied emphasis brought by "does". I put it in original comment the first time I used fixed sha to emphasize the fact it's sha taken after compatibility patches were merged upstream. However, as this becoming a default situation now it doesn't need emphasis anymore but it's carried over by Mr Copy Paste.
I'll clean it up.
The bug that was causing Scala compiler crash in spire's tests has been fixed upstream. We can build entire spire now.
Support for Scala 2.11 is becoming a default now. No need to emphasize that anymore.
|
@retronym: feedback addressed I tested these changes locally. The build passes. |
Add spire and discipline projects
|
LGTM |
Discipline is a dependency of spire so it joined the family too :-)