Skip to content

add scala-newtype and fast-string-interpolator #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 20, 2018
Merged

add scala-newtype and fast-string-interpolator #697

merged 4 commits into from
Mar 20, 2018

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

SethTisue commented Mar 20, 2018 •
edited
Loading

test run queued: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2687/ (404 til Jenkins finishes rousing the thunder gods from their drunken slumber)

@SethTisue
Copy link
Member Author

try again: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2688/consoleFull

@SethTisue SethTisue changed the title add scala-newtype add scala-newtype and fast-string-interpolator Mar 20, 2018
@SethTisue
Copy link
Member Author

since it also came up at scala/scala-dev#480, attempting to add fast-string-interpolator as well. fyi @Sizmek @estatico

@SethTisue
Copy link
Member Author

https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2692/consoleFull

plokhotnyuk
plokhotnyuk reviewed Mar 20, 2018
View reviewed changes
configs/community.dbuild
"set every bintrayReleaseOnPublish := false"
]
// Missing dependency: com.dongxiguo#fastring
extra.exclude: ["benchmark"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have isolated 3rd party interpolators in this module, to reproduce bug with macros compilation in benchmark-core: plokhotnyuk/fast-string-interpolator@346b61d

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll do at least one more run before merging, in order to test that change.

@SethTisue SethTisue self-assigned this Mar 20, 2018
@SethTisue
Copy link
Member Author

@plokhotnyuk at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2693/consoleFull I'm seeing

[fast-string-interpolator] [error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.11/project-builds/fast-string-interpolator-648a123d269031c17bdf894a6c53589c732c9744/benchmark-core/src/test/scala/com/sizmek/fsi/benchmark/StringConcatenationBenchmarkCoreSpec.scala:6:31: not found: type StringConcatenationBenchmark
[fast-string-interpolator] [error]   private val benchmark = new StringConcatenationBenchmark
[fast-string-interpolator] [error]                               ^

?

@plokhotnyuk
Copy link
Contributor

plokhotnyuk commented Mar 20, 2018 •
edited
Loading

Sorry, have fixed it by plokhotnyuk/fast-string-interpolator@a961515

It looks like cross-module dependencies are allowed, while wasn't declared... Should I report it to SBT team?

@SethTisue
Copy link
Member Author

green at https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/2694/console

@SethTisue SethTisue merged commit f421ea7 into scala:2.12.x Mar 20, 2018
@SethTisue SethTisue deleted the add-scala-newtype branch March 20, 2018 15:47
@SethTisue
Copy link
Member Author

👍 thank you for your early testing of 2.12.5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plokhotnyuk plokhotnyuk plokhotnyuk left review comments

Assignees

@SethTisue SethTisue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SethTisue @plokhotnyuk