Skip to content

broken link on mixins page #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SethTisue opened this issue May 15, 2017 · 8 comments · Fixed by #788
Closed

broken link on mixins page #771

SethTisue opened this issue May 15, 2017 · 8 comments · Fixed by #788

Comments

@SethTisue
Copy link
Member

reported by a user at http://docs.scala-lang.org/tutorials/tour/mixin-class-composition.html#comment-3302979592
travissarles added a commit to travissarles/scala.github.com that referenced this issue May 16, 2017
@travissarles
Fixed broken link closes scala#771
84f72e9
travissarles added a commit to travissarles/scala.github.com that referenced this issue May 16, 2017
@travissarles
Fixed broken link closes scala#771
bd34c28
travissarles added a commit to travissarles/scala.github.com that referenced this issue May 16, 2017
@travissarles
Fixed broken link closes scala#771
5239edc
@Philippus
Copy link
Member

Philippus commented May 17, 2017 •
edited
Loading

Is the link broken or is the topic missing?
asking because I see some more:

  • references to xml-processing.html
  • references to automatic-closures.html

@SethTisue
Copy link
Member Author

yeah I wouldn't be surprised if the one-PR-at-a-time merging of the various tour revisions has resulted in similar breakage throughout

@SethTisue
Copy link
Member Author

SethTisue commented May 17, 2017 •
edited
Loading

(over in scala-lang, we have a Travis build https://github.com/scala/scala-lang/blob/master/.travis.yml which catches at least some of these things before they even get merged; it would be really helpful to have something similar in this repo)

@SethTisue SethTisue mentioned this issue May 30, 2017
Closed
@SethTisue
Copy link
Member Author

I forgot we use Drone, not Travis, in this repo. but, I don't know why the Drone build didn't catch this bug.

travissarles added a commit to travissarles/scala.github.com that referenced this issue May 31, 2017
@travissarles
Fixed broken link closes scala#771
c337de1
@SethTisue
Copy link
Member Author

@travissarles this is being reported over and over again in the Disqus comments on the page — could you prioritize a fix?

Philippus added a commit to Philippus/scala.github.com that referenced this issue Jun 4, 2017
@Philippus
Skip non-existing 'anonymous-function-syntax' page, fixes scala#771
35ad0cc
@Philippus Philippus mentioned this issue Jun 4, 2017
Merged
@Philippus
Copy link
Member

@SethTisue there you go.

SethTisue added a commit that referenced this issue Jun 4, 2017
@SethTisue
Merge pull request #788 from Philippus/issue/771
578cab1 
Skip non-existing 'anonymous-function-syntax' page (#771)
@travissarles
Copy link
Contributor

@SethTisue it looks like my changes from 4 days ago fixed it. Are you still seeing it?

@SethTisue
Copy link
Member Author

@Philippus fixed it in #788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip non-existing 'anonymous-function-syntax' page (#771) Philippus/scala.github.com
3 participants
@SethTisue @Philippus @travissarles