Tabs for Scala 2/3 in some pages #2455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jul 5, 2022
bishabosha
reviewed
Jul 5, 2022
julienrf
requested changes
Jul 5, 2022
bishabosha
reviewed
Jul 5, 2022
bishabosha
reviewed
Jul 5, 2022
| This method can also be available on implicit scope. To define our own string interpolation, we simply need to create an implicit class that adds a new method | ||
| to `StringContext`. Here's an example: | ||
| This method can also be available on implicit scope. | ||
| To define our own string interpolation, we need to create an implicit class (Scala 2) or an `extension` method (Scala 3) that adds a new method to `StringContext`. |
There was a problem hiding this comment.
instead of mentioning both Scala 2 and Scala 3 in this sentence, you could add a specialised line of text to either tab
There was a problem hiding this comment.
It doesn't really "look well" if I do that, IMO.
julienrf
approved these changes
Jul 5, 2022
bishabosha
approved these changes
Jul 5, 2022
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.