Add code tabs for _tour/pattern-matching and scala3-book/control-structures #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jul 5, 2022
adpi2
force-pushed
the
some-tabs
branch
2 times, most recently
from
48790c3 to
52602f7
Compare
julienrf
requested changes
Jul 5, 2022
bishabosha
reviewed
Jul 5, 2022
bishabosha
reviewed
Jul 5, 2022
bishabosha
reviewed
Jul 6, 2022
bishabosha
approved these changes
Jul 6, 2022
julienrf
approved these changes
Jul 6, 2022
There was a problem hiding this comment.
I think more work is needed about sealed (e.g. showing more explicitly that it’s impossible to extend a sealed type from a different file, and that the compiler performs exhaustivity checking).
I understand that this is going too far beyond the scope of the original PR, so I am fine with merging this PR as it is and improve it later. Thanks a lot Adrien for your work!
|
Thanks for your reviews. It seems I don't have the right to merge so please go ahead. |
This was referenced Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.