Skip to content

Add SIP meeting results #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions _layouts/sip-meeting-results.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
layout: sips
---

<p>The Committee discussed and voted on the proposals listed below.</p>

<table>
<thead>
<tr><th>Proposal</th><th>Result</th></tr>
</thead>
<tbody>
{% for proposal in page.proposals %}
<tr>
<td><a href="{{ proposal.url }}">{{proposal.name}}</a></td>
<td>
{% if proposal.result == 'rejected' %}
Rejected <span class="fa fa-xmark"></span>
{% elsif proposal.result == 'accepted' %}
Accepted <span class="fa fa-check"></span>
{% else %}
Under Review <span class="fa fa-clipboard-list"></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is ok for now, but on low resolution displays the clipboard icon is not clear at this size, I suggest maybe a clock as a follow up PR

Suggested change
Under Review <span class="fa fa-clipboard-list"></span>
Under Review <span class="fa fa-clock"></span>

{% endif %}
</td>
</tr>
{% endfor %}
</tbody>
</table>
3 changes: 1 addition & 2 deletions _layouts/sips.html
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ <h5 class="contents" style="margin-bottom: 0;">SIP Meetings</h5>
<div id="sip-meetings">
<div id="meeting-minutes">
<ul>
<li><a href="{{ site.baseurl }}/sips/minutes-list.html">Meeting Minutes</a></li>
<li><a href="https://www.youtube.com/channel/UCn_8OeZlf5S6sqCqntAvaIw/videos?view=2&sort=dd&shelf_id=1&live_view=502">Meeting Video Registrations (YouTube)</a></li>
<li><a href="{{ site.baseurl }}{% link _sips/meeting-results.md %}">Meeting Results</a></li>
</ul>
</div>
</div>
Expand Down
32 changes: 32 additions & 0 deletions _sips/meeting-results.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
---
layout: sips
title: SIP Meeting Results
redirect_from: /sips/minutes-list.html
---

This page lists the results of every SIP meeting, starting from July 2016.

### Meetings ###

<ul class="minute-list">
{% assign sips = site.sips | sort: 'date' | reverse %}
{% for page in sips %}
{% if page.partof == 'results' %}
<li><a href="{{ site.baseurl }}{{ page.url }}">{{ page.date | date_to_long_string }}</a></li>
{% endif %}
{% endfor %}
</ul>

### Meeting Minutes ###

Before 2022, we hosted the complete meeting notes (minutes). Some
meetings were also [recorded on YouTube](https://www.youtube.com/channel/UCn_8OeZlf5S6sqCqntAvaIw/videos?view=2&sort=dd&shelf_id=1&live_view=502).

<ul class="minute-list">
{% assign sips = site.sips | sort: 'date' | reverse %}
{% for pg in sips %}
{% if pg.partof == 'minutes' %}
<li><a href="{{ site.baseurl }}{{ pg.url }}">{{ pg.title }}</a></li>
{% endif %}
{% endfor %}
</ul>
17 changes: 0 additions & 17 deletions _sips/minutes-list.md

This file was deleted.

25 changes: 25 additions & 0 deletions _sips/results/2022-08-26-meeting.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
---
layout: sip-meeting-results
title: SIP Meeting Results - 26th August 2022
partof: results
proposals:
- url: https://github.com/scala/improvement-proposals/pull/29
name: SIP-32 - Allow referring to other arguments in default parameters
result: rejected
- url: https://github.com/scala/improvement-proposals/pull/37
name: SIP-39 - Uncluttering Abuse of Match
result: rejected
- url: https://docs.scala-lang.org/sips/binary-integer-literals.html
name: SIP-42 - Binary Integer Literals
result: accepted
- url: https://github.com/scala/improvement-proposals/pull/42
name: SIP-40 - Name Based XML Literals
result: rejected
- url: https://github.com/scala/improvement-proposals/pull/41
name: SIP-45 - Curried varargs
result: rejected
- url: https://docs.scala-lang.org/sips/fewer-braces.html
name: SIP-44 - Fewer braces
result: accepted
---

4 changes: 2 additions & 2 deletions index.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ sections:

- title: "Scala Evolution"
links:
- title: "SIPs"
description: "The Scala Improvement Process. Language & compiler evolution."
- title: "Scala Improvement Process"
description: "Description of the process for evolving the language, and list of all the Scala Improvement Proposals (SIPs)."
icon: "fa fa-cogs"
link: /sips/index.html
- title: "Become a Scala OSS Contributor"
Expand Down