Add code tabs for _tour/higher-order-functions #2525
Conversation
_tour/higher-order-functions.md
Outdated
|
|
||
| {% tabs map_example_1 class=tabs-scala-version %} | ||
|
|
||
| {% tab 'Scala 2' for=map_example_1 %} |
There was a problem hiding this comment.
surely this tab could be Scala 2 and 3? (scala 2 supports underscores in numeric literals)
There was a problem hiding this comment.
I have try, but it was refused by mdocstep (see 8e87cbb) if I understand well...
There was a problem hiding this comment.
Right I didn't check the other commits, that's unfortunate, perhaps the mdoc configuration is outdated. However I'd still prefer to have 1 tab without the underscores - I don't think they are a fundamental improvement because at least for now our syntax highlighting doesn't support it
There was a problem hiding this comment.
Ok. If fact, mdoc look like to check with scala 2.12.4, that does not support such constant...
We just have to not use "mdoc". I will perform the change.
_tour/higher-order-functions.md
Outdated
|
|
||
| {% tabs map_example_2 class=tabs-scala-version %} | ||
|
|
||
| {% tab 'Scala 2' for=map_example_2 %} |
_tour/higher-order-functions.md
Outdated
|
|
||
| {% tabs map_example_3 class=tabs-scala-version %} | ||
|
|
||
| {% tab 'Scala 2' for=map_example_3 %} |
There was a problem hiding this comment.
and here, you can have underscores in scala 2
|
updated #2481 |
2 participants
No description provided.