Skip to content

Conversation

@flomebul
Copy link
Contributor

@flomebul flomebul commented Oct 6, 2022

Not so simple, so I expect to be re-read carefully by experts...

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Philippus
Philippus previously approved these changes Oct 8, 2022
@Philippus Philippus dismissed their stale review October 8, 2022 20:36

accidentally approved

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I have finished making suggestions, I think the changes are good but there can be some cleanup

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!!

@bishabosha bishabosha merged commit 57ebc7d into scala:main Oct 9, 2022
@flomebul flomebul deleted the custom-operations branch October 9, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants