Skip to content

Conversation

@benluo
Copy link
Contributor

@benluo benluo commented Oct 7, 2022

No description provided.

benluo and others added 2 commits October 12, 2022 19:26
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
benluo and others added 2 commits October 17, 2022 21:29
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
benluo and others added 2 commits October 17, 2022 21:35
> This method works just like the previous method that used an `if`/`else` expression. We use `Matchable` instead of `Any` as the parameter's type to accept any value that supports pattern matching.
For more details on the `Matchable` trait, see the [Reference documentation][reference_matchable].
> For more details on the `Matchable` trait, see the [Reference documentation][reference_matchable].
Copy link
Member

@bishabosha bishabosha Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why yet but it seems the code tabs plugin does not resolve these links - probably because it sees each tab as an individual markdown document, so I experimented and duplicating the link definition into the tab works

Suggested change
> For more details on the `Matchable` trait, see the [Reference documentation][reference_matchable].
> For more details on the `Matchable` trait, see the [Reference documentation][reference_matchable].
[reference_matchable]: {{ site.scala3ref }}/other-new-features/matchable.html

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work

@bishabosha bishabosha merged commit 17b0a49 into scala:main Oct 19, 2022
@benluo benluo deleted the _overview/scala3-book/num24-code-tabs branch October 19, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants