Skip to content

Conversation

@benluo
Copy link
Contributor

@benluo benluo commented Nov 18, 2022

No description provided.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the time to do this, but please could you add the "scala 3 only" tag to the top of the page somehow, such as was done with http://localhost:4000/scala3/book/methods-main-methods.html.

then going forwards we can also have a page for "implicit" (scala 2 style) and then a page that abstracts over the use cases of the two. Otherwise if we do not make separate pages, then this page should also cover the scala 2 way

@alvinj @julienrf what do you think?

benluo and others added 7 commits November 19, 2022 02:49
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
@benluo
Copy link
Contributor Author

benluo commented Nov 18, 2022

Thank you for taking the time to do this, but please could you add the "scala 3 only" tag to the top of the page somehow, such as was done with http://localhost:4000/scala3/book/methods-main-methods.html.

then going forwards we can also have a page for "implicit" (scala 2 style) and then a page that abstracts over the use cases of the two. Otherwise if we do not make separate pages, then this page should also cover the scala 2 way

@alvinj @julienrf what do you think?

I add one line as the first line.

Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! However please be aware that we are separately working on some PR to change the contextual abstractions section quite a bit

@bishabosha bishabosha merged commit c810264 into scala:main Nov 18, 2022
@benluo benluo deleted the overview/scala3-book/num59-code-tabs branch November 19, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants